| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ba289e556bb1ac0f6bd743e295164c59@codeaurora.org>
Date: Fri, 14 Dec 2018 21:59:56 +0530
From: Sibi Sankar <sibis@...eaurora.org>
To: Doug Anderson <dianders@...omium.org>
Cc: Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Andy Gross <andy.gross@...aro.org>,
David Brown <david.brown@...aro.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
tsoni@...eaurora.org, clew@...eaurora.org, akdwived@...eaurora.org,
Mark Rutland <mark.rutland@....com>,
linux-remoteproc@...r.kernel.org,
Evan Green <evgreen@...omium.org>,
Brian Norris <briannorris@...omium.org>,
linux-remoteproc-owner@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Add Q6V5 MSS node
Hi Doug,
Thanks for the review!
On 2018-12-14 03:47, Doug Anderson wrote:
> Hi,
>
> On Tue, Nov 27, 2018 at 12:58 AM Sibi Sankar <sibis@...eaurora.org>
> wrote:
>>
>> This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
>>
>> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
>> ---
>>
>> The remoteproc mss node depends on the following bindings:
>> https://patchwork.kernel.org/patch/10490559/ - rpmhp dt bindings
>
> This is an older version of the patch. Now at v7 at
> <https://patchwork.kernel.org/patch/10725801/>
>
>
>> https://patchwork.kernel.org/patch/10678301/ - AOP QMP dt bindings
>> https://patchwork.kernel.org/patch/10691215/ - mss power-domain dt
>> bindings
>> https://patchwork.kernel.org/patch/10691213/ - shutdown-ack dt
>> bindings
>>
>> It also depends on the mpss and mba memory regions and pdc reset node.
>> https://patchwork.kernel.org/patch/10662089/
>> https://patchwork.kernel.org/patch/10657325/
>>
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 63
>> ++++++++++++++++++++++++++++
>> 1 file changed, 63 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index 58870273dbc9..df16ee464872 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -1095,6 +1095,69 @@
>> };
>> };
>>
>> + remoteproc@...0000 {
>> + compatible = "qcom,sdm845-mss-pil";
>> + reg = <0x04080000 0x408>, <0x04180000 0x48>;
>
> s/0x04080000/0x4080000 to appease the DT folks.
>
as you said in the other thread will leave the
padding untouched
>
>> + reg-names = "qdsp6", "rmb";
>> +
>> + interrupts-extended =
>> + <&intc GIC_SPI 266
>> IRQ_TYPE_EDGE_RISING>,
>> + <&modem_smp2p_in 0
>> IRQ_TYPE_EDGE_RISING>,
>> + <&modem_smp2p_in 1
>> IRQ_TYPE_EDGE_RISING>,
>> + <&modem_smp2p_in 2
>> IRQ_TYPE_EDGE_RISING>,
>> + <&modem_smp2p_in 3
>> IRQ_TYPE_EDGE_RISING>,
>> + <&modem_smp2p_in 7
>> IRQ_TYPE_EDGE_RISING>;
>> +
>> + interrupt-names = "wdog", "fatal", "ready",
>> + "handover", "stop-ack",
>> + "shutdown-ack";
>
> nit: maybe remove blank line between "interrupts-extended" and
> "interrupt-names". Nice to keep -names close to the things they're
> naming.
>
sure will do that.. I guess I'll have to remove
the blank line in clock-names as well
>
>> + clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
>> + <&gcc GCC_MSS_Q6_MEMNOC_AXI_CLK>,
>> + <&gcc GCC_BOOT_ROM_AHB_CLK>,
>> + <&gcc GCC_MSS_GPLL0_DIV_CLK_SRC>,
>> + <&gcc GCC_MSS_SNOC_AXI_CLK>,
>> + <&gcc GCC_MSS_MFAB_AXIS_CLK>,
>> + <&gcc GCC_PRNG_AHB_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
>> +
>> + clock-names = "iface", "bus", "mem",
>> "gpll0_mss",
>> + "snoc_axi", "mnoc_axi", "prng",
>> "xo";
>
> Bindings list clock-names as "iface", "bus", "mem". You have "iface",
> "bus", "mem", "gpll0_mss", "snoc_axi", "mnoc_axi", "prng", "xo". It
> looks like these extra clocks were added in commit 231f67d1fb2f
> ("remoteproc: q6v5: Add support for mss remoteproc on SDM845") but you
> forgot to update the bindings. Looking in that patch I also see an
> "axis2" which you seem to be missing. Do you need it?
>
yes missed adding them..will add them in the next respin
>
>> + qcom,smem-states = <&modem_smp2p_out 0>;
>> + qcom,smem-state-names = "stop";
>> +
>> + resets = <&aoss_reset AOSS_CC_MSS_RESTART>,
>> + <&pdc_reset PDC_MODEM_SYNC_RESET>;
>> + reset-names = "mss_restart", "pdc_reset";
>> +
>> + qcom,halt-regs = <&tcsr_mutex_regs
>> + 0x23000 0x25000
>> 0x24000>;
>> +
>> + power-domains = <&aoss_qmp_pd
>> AOSS_QMP_LS_MODEM>,
>> + <&rpmhpd SDM845_CX>,
>> + <&rpmhpd SDM845_MX>,
>> + <&rpmhpd SDM845_MSS>;
>> + power-domain-names = "aop", "cx", "mx", "mss";
>> +
>> + mba {
>> + memory-region = <&mba_region>;
>> + };
>> +
>> + mpss {
>> + memory-region = <&mpss_region>;
>> + };
>> +
>> + glink-edge {
>> + interrupts = <GIC_SPI 449
>> IRQ_TYPE_EDGE_RISING>;
>> + label = "modem";
>> + qcom,remote-pid = <1>;
>
> The "qcom,remote-pid" property isn't documented for "glink-edge". Do
> you need it? ...if you do, please send a patch to update the
> bindings.
>
yes glink seems to be missing the remote-pid..
I will add that as well in v2
>
> -Doug
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists