linux-kernel - Re: [PATCH v2] Compiler Attributes: don't pollute userspace with macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOd=uKhwdnv0gH3E4_C=_uCGUvsWObpd_asMRX0ZQn4Qbyg@mail.gmail.com>
Date:   Fri, 14 Dec 2018 09:47:33 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     liuxiaozhou@...edance.com, Greg KH <gregkh@...uxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        paul.burton@...s.com, Arnd Bergmann <arnd@...db.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v2] Compiler Attributes: don't pollute userspace with
 macro definitions

On Fri, Dec 14, 2018 at 2:02 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Thu, Dec 13, 2018 at 11:25 PM Nick Desaulniers
> <ndesaulniers@...gle.com> wrote:
> >
> > Moving the __KERNEL__ guard should not affect the kernel, only what
> > userspace sees.  __gnu_inline only affects which
> > implementation/definition you get, so even if userspace doesn't know
> > what the kernel's inline is redefined to, it should not matter as
> > userspace should only ever care about the function signature, which
> > does not change between our definitions of inline.
>
> Hm... I am unsure what you mean by this. Were you replying to me or to
> the original patch?

Justifying my thoughts for ack'ing the original patch.

-- 
Thanks,
~Nick Desaulniers