linux-kernel - Re: [PATCH v6 08/27] csky: define syscall_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181214044412.GB15793@guoren-Inspiron-7460>
Date:   Fri, 14 Dec 2018 12:44:12 +0800
From:   Guo Ren <guoren@...nel.org>
To:     "Dmitry V. Levin" <ldv@...linux.org>
Cc:     Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Elvira Khabirova <lineprinter@...linux.org>,
        Eugene Syromyatnikov <esyr@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 08/27] csky: define syscall_get_arch()

Thx Dmitry,

Reviewed-by: Guo Ren <guoren@...nel.org>

On Thu, Dec 13, 2018 at 08:22:07PM +0300, Dmitry V. Levin wrote:
> syscall_get_arch() is required to be implemented on all architectures
> in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO
> request.
> 
> Cc: Guo Ren <guoren@...nel.org>
> Cc: Paul Moore <paul@...l-moore.com>
> Cc: Eric Paris <eparis@...hat.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Elvira Khabirova <lineprinter@...linux.org>
> Cc: Eugene Syromyatnikov <esyr@...hat.com>
> Cc: linux-audit@...hat.com
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> ---
> 
> Notes:
>     v6: unchanged
> 
>  arch/csky/include/asm/syscall.h | 7 +++++++
>  include/uapi/linux/audit.h      | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/arch/csky/include/asm/syscall.h b/arch/csky/include/asm/syscall.h
> index 926a64a8b4ee..d637445737b7 100644
> --- a/arch/csky/include/asm/syscall.h
> +++ b/arch/csky/include/asm/syscall.h
> @@ -6,6 +6,7 @@
>  #include <linux/sched.h>
>  #include <linux/err.h>
>  #include <abi/regdef.h>
> +#include <uapi/linux/audit.h>
>  
>  static inline int
>  syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
> @@ -68,4 +69,10 @@ syscall_set_arguments(struct task_struct *task, struct pt_regs *regs,
>  	memcpy(&regs->a1 + i * sizeof(regs->a1), args, n * sizeof(regs->a0));
>  }
>  
> +static inline int
> +syscall_get_arch(void)
> +{
> +	return AUDIT_ARCH_CSKY;
> +}
> +
>  #endif	/* __ASM_SYSCALL_H */
> diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
> index 72aeea0a740d..55904a40d768 100644
> --- a/include/uapi/linux/audit.h
> +++ b/include/uapi/linux/audit.h
> @@ -384,6 +384,7 @@ enum {
>  #define AUDIT_ARCH_C6X		(EM_TI_C6000|__AUDIT_ARCH_LE)
>  #define AUDIT_ARCH_C6XBE	(EM_TI_C6000)
>  #define AUDIT_ARCH_CRIS		(EM_CRIS|__AUDIT_ARCH_LE)
> +#define AUDIT_ARCH_CSKY		(EM_CSKY|__AUDIT_ARCH_LE)
>  #define AUDIT_ARCH_FRV		(EM_FRV)
>  #define AUDIT_ARCH_I386		(EM_386|__AUDIT_ARCH_LE)
>  #define AUDIT_ARCH_IA64		(EM_IA_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
> -- 
> ldv