linux-kernel - Re: [PATCH] hns3: prevent building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.132044.183096780468259380.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 13:20:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        lipeng321@...wei.com, tanhuazhong@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hns3: prevent building without CONFIG_INET

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 10 Dec 2018 21:44:34 +0100

> We now get a link failure when CONFIG_INET is disabled, since
> tcp_gro_complete is unavailable:
> 
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.o: In function `hns3_set_gro_param':
> hns3_enet.c:(.text+0x230c): undefined reference to `tcp_gro_complete'
> 
> Add an explicit CONFIG_INET dependency here to avoid the broken
> configuration.
> 
> Fixes: a6d53b97a2e7 ("net: hns3: Adds GRO params to SKB for the stack")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.