linux-kernel - Re: [PATCH] drivers: net: xgene: Remove unnecessary forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.133546.2181294450034085842.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 13:35:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     isubramanian@....com, kchudgar@....com, qnguyen@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: xgene: Remove unnecessary forward
 declarations

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon, 10 Dec 2018 21:20:30 -0700

> Clang warns:
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c:33:36: warning:
> tentative array definition assumed to have one element
> static const struct acpi_device_id xgene_enet_acpi_match[];
>                                    ^
> 1 warning generated.
> 
> Both xgene_enet_acpi_match and xgene_enet_of_match are defined before
> their uses at the bottom of the file so this is unnecessary. When
> CONFIG_ACPI is disabled, ACPI_PTR becomes NULL so xgene_enet_acpi_match
> doesn't need to be defined.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied.