linux-kernel - Re: [PATCH] net/ibmvnic: Remove tests of member address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.133657.253891930157421703.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 13:36:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     wen.yang99@....com.cn
Cc:     tlfalcon@...ux.ibm.com, jallen@...ux.ibm.com,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, cheng.shengyu@....com.cn
Subject: Re: [PATCH] net/ibmvnic: Remove tests of member address

From: Wen Yang <wen.yang99@....com.cn>
Date: Tue, 11 Dec 2018 12:20:46 +0800

> The driver was checking for non-NULL address.
> - adapter->napi[i]
> 
> This is pointless as these will be always non-NULL, since the
> 'dapter->napi' is allocated in init_napi().
> It is safe to get rid of useless checks for addresses to fix the
> coccinelle warning:
>>>drivers/net/ethernet/ibm/ibmvnic.c: test of a variable/field address
> Since such statements always return true, they are redundant.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>

Applied.