linux-kernel - Re: Unwinding regression with 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDihLFgOmkumZ-W4i=5oOb1Zu+BHJz8M-WphYYyAdb9jYdL+g@mail.gmail.com>
Date:   Fri, 14 Dec 2018 14:24:27 -0800
From:   Alistair Strachan <astrachan@...gle.com>
To:     labbott@...hat.com
Cc:     luto@...nel.org, tglx@...utronix.de, hpa@...or.com,
        kernel-team@...roid.com, joel@...lfernandes.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, fweimer@...hat.com,
        carlos@...hat.com, hjl.tools@...il.com
Subject: Re: Unwinding regression with 379d98ddf413 ("x86: vdso: Use $LD
 instead of $CC to link")

Hi Laura,

On Fri, Dec 14, 2018 at 1:48 PM Laura Abbott <labbott@...hat.com> wrote:
> Hi,
>
> There are two reports of a regression with unwinding with
> 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")
>
> https://bugzilla.kernel.org/show_bug.cgi?id=201741
> https://bugzilla.redhat.com/show_bug.cgi?id=1659295
>
> It looks like the unwinding information has been
> stripped out. Any ideas?

Sorry about this. I missed a critical flag (--eh-frame-hdr) that gcc
specifies implicitly when converting the Makefile to invoke ld
directly. This went unnoticed because the linking of vmlinux (which
also uses ld directly) does not need this information, so it does not
specify the flag. Sending a verified fix now.

> Thanks,
> Laura