linux-kernel - Re: [PATCH] x86: vdso: Pass --eh-frame-hdr to ld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ab89a22-90af-9e57-a35f-7b478d8c62d5@redhat.com>
Date:   Fri, 14 Dec 2018 14:32:06 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Alistair Strachan <astrachan@...gle.com>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        Florian Weimer <fweimer@...hat.com>,
        Carlos O'Donell <carlos@...hat.com>,
        "H. J. Lu" <hjl.tools@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        kernel-team@...roid.com
Subject: Re: [PATCH] x86: vdso: Pass --eh-frame-hdr to ld

On 12/14/18 2:27 PM, Alistair Strachan wrote:
> Commit 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")
> accidentally broke unwinding from userspace, because ld would strip the
> .eh_frame sections when linking.
> 
> Originally, the compiler would implicitly add --eh-frame-hdr when
> invoking the linker, but when this Makefile was converted from invoking
> ld via the compiler, to invoking it directly (like vmlinux does),
> the flag was missed. (The EH_FRAME section is important for the VDSO
> shared libraries, but not for vmlinux.)
> 
> Fix the problem by explicitly specifying --eh-frame-hdr, which restores
> parity with the old method.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201741
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1659295
> Reported-by: Laura Abbott <labbott@...hat.com>

You should probably use the bugzilla reporters instead
of me given I just did the boring part of sending an e-mail.
Instead you can use:

Tested-by: Laura Abbott <labbott@...hat.com>

> Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")
> Cc: stable@...r.kernel.org
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: X86 ML <x86@...nel.org>
> Cc: Florian Weimer <fweimer@...hat.com>,
> Cc: Carlos O'Donell <carlos@...hat.com>,
> Cc: "H. J. Lu" <hjl.tools@...il.com>
> Cc: Joel Fernandes <joel@...lfernandes.org>
> Cc: kernel-team@...roid.com
> Signed-off-by: Alistair Strachan <astrachan@...gle.com>
> ---
>   arch/x86/entry/vdso/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
> index 141d415a8c80..c3d7ccd25381 100644
> --- a/arch/x86/entry/vdso/Makefile
> +++ b/arch/x86/entry/vdso/Makefile
> @@ -171,7 +171,8 @@ quiet_cmd_vdso = VDSO    $@
>   		 sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@'
>   
>   VDSO_LDFLAGS = -shared $(call ld-option, --hash-style=both) \
> -	$(call ld-option, --build-id) -Bsymbolic
> +	$(call ld-option, --build-id) $(call ld-option, --eh-frame-hdr) \
> +	-Bsymbolic
>   GCOV_PROFILE := n
>   
>   #
>