linux-kernel - Re: [PATCH 5/7] [stable-4.19] i2c: aspeed: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFd5g45GxxhHuyHWDjd41_8xscYN6p5XJShnmg9Z2-DDGwaE4A@mail.gmail.com>
Date:   Fri, 14 Dec 2018 15:30:16 -0800
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Joel Stanley <joel@....id.au>, stable@...r.kernel.org,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        linux-aspeed@...ts.ozlabs.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/7] [stable-4.19] i2c: aspeed: fix build warning

On Fri, Dec 14, 2018 at 2:12 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> Upstream commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events
> properly") reworked the interrupt handling and fixed a warning in the process:
>
> drivers/i2c/busses/i2c-aspeed.c: In function 'aspeed_i2c_bus_irq':
> drivers/i2c/busses/i2c-aspeed.c:567:1: error: label 'out' defined but not used [-Werror=unused-label]
>
> The warning is still present in v4.19.8 and can be fixed either by applying
> that original patch, or by adding a simple #ifdef.
>
> Here, I choose the second simpler option as the original patch seems too
> invasive for a stable backport.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks!

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>