linux-kernel - Re: [PATCH] partitions: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1fd45ed-a482-f387-687c-cb4375367a67@codeaurora.org>
Date:   Fri, 14 Dec 2018 14:17:37 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     jotun9935@...il.com, axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] partitions: fix coding style



On 12/14/2018 12:34 PM, jotun9935@...il.com wrote:
> From: Sungkyung Kim <jotun9935@...il.com>
>
> Fix coding style of osf.c
>
> Signed-off-by: Sungkyung Kim <jotun9935@...il.com>
> ---
>   block/partitions/osf.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/partitions/osf.c b/block/partitions/osf.c
> index 4b873973d6c0..96921a1e31ce 100644
> --- a/block/partitions/osf.c
> +++ b/block/partitions/osf.c
> @@ -22,7 +22,7 @@ int osf_partition(struct parsed_partitions *state)
>   	unsigned char *data;
>   	struct disklabel {
>   		__le32 d_magic;
> -		__le16 d_type,d_subtype;
> +		__le16 d_type, d_subtype;
>   		u8 d_typename[16];
>   		u8 d_packname[16];
>   		__le32 d_secsize;
> @@ -50,8 +50,8 @@ int osf_partition(struct parsed_partitions *state)
>   			u8  p_frag;
>   			__le16 p_cpg;
>   		} d_partitions[MAX_OSF_PARTITIONS];

Also include this change as well

--- a/block/partitions/osf.c
+++ b/block/partitions/osf.c
@@ -57,7 +57,7 @@ int osf_partition(struct parsed_partitions *state)
         if (!data)
                 return -1;

-       label = (struct disklabel *) (data+64);
+       label = (struct disklabel *) (data + 64);
         partition = label->d_partitions;


would be better a bit more you add in your changelog.

Cheers,
Mukesh
> -	} * label;
> -	struct d_partition * partition;
> +	} *label;
> +	struct d_partition *partition;
>   
>   	data = read_part_sector(state, 0, &sect);
>   	if (!data)
> @@ -74,7 +74,7 @@ int osf_partition(struct parsed_partitions *state)
>   	}
>   	for (i = 0 ; i < npartitions; i++, partition++) {
>   		if (slot == state->limit)
> -		        break;
> +			break;
>   		if (le32_to_cpu(partition->p_size))
>   			put_partition(state, slot,
>   				le32_to_cpu(partition->p_offset),