linux-kernel - Re: [PATCH v2] clk: qcom: Drop unused 8998 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Dec 2018 17:32:58 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jeffrey Hugo <jhugo@...eaurora.org>, andy.gross@...aro.org,
        david.brown@...aro.org, mturquette@...libre.com
Cc:     bjorn.andersson@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        marc.w.gonzalez@...e.fr
Subject: Re: [PATCH v2] clk: qcom: Drop unused 8998 clock

Quoting Jeffrey Hugo (2018-12-13 14:32:12)
> On 12/13/2018 12:38 PM, Stephen Boyd wrote:
> > Quoting Jeffrey Hugo (2018-12-13 09:09:09)
> >> gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
> >> expect it to be needed for clients.  Let's remove it because messing with
> >> the clock has been observed to cause Linux hangs when the qdss_clk is
> >> initialized by rpmcc.
> >>
> >> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> >> Reviewed-by: Marc Gonzalez <marc.w.gonzalez@...e.fr>
> >> ---
> >>
> >> v2:
> >> -corrected commit text per Marc
> >> -added Marc's reviewed-by
> > 
> > Please slow down. There isn't any need to resend for such things.
> > 
> 
> Sorry.  Used to other maintainers.
>  From your v1 comment, would be
> Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support)
> I'm assuming from the above, you'll just apply the tag when you apply 
> the change.
> 

Hmm I already marked it as 'changes requested' but OK, I can pick it up
and add the fixes tag now.