linux-kernel - RE: [PATCH v4] PM / devfreq: Restart previous governor if new governor fails to start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181214014527epcms1p6c783b4cd1602bbcbcb6e725f840db479@epcms1p6>
Date:   Fri, 14 Dec 2018 10:45:27 +0900
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Kyungmin Park <kyungmin.park@...sung.com>
CC:     Chanwoo Choi <cw00.choi@...sung.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm-owner@...r.kernel.org" 
        <linux-arm-msm-owner@...r.kernel.org>,
        "skannan@...eaurora.org" <skannan@...eaurora.org>,
        Sibi Sankar <sibis@...eaurora.org>
Subject: RE: [PATCH v4] PM / devfreq: Restart previous governor if new
 governor fails to start

> From: Saravana Kannan <skannan@...eaurora.org>
> 
> If the new governor fails to start, switch back to old governor so that the
> devfreq state is not left in some weird limbo.
> 
> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
> Signed-off-by: Saravana Kannan <skannan@...eaurora.org>
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Hello,

In overall, the idea and the implementation looks good.

However, I have a question:

What if the following line fails?

+		df->governor->event_handler(df, DEVFREQ_GOV_START,
+					    NULL);

Don't we still need something to handle for such events?

Cheers,
MyungJoo