linux-kernel - Re: ASoC: About graph node issue without 'reg' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181214111358.FB47.4A936039@socionext.com>
Date:   Fri, 14 Dec 2018 11:13:59 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>
Subject: Re: ASoC: About graph node issue without 'reg' property

Hi Morimoto-san, Mark,

On Fri, 14 Dec 2018 09:05:02 +0900 <kuninori.morimoto.gx@...esas.com> wrote:

> 
> Hi Hayashi-san
> 
> Sorry for my buggy patch.
> I and Tony could confirm that my posted patch can solve
> this issue. I will re-post it again as v3 patch-series.
> I'm happy if you can test it (and give it Tested-by).
> 
> 	https://patchwork.kernel.org/patch/10727943/

Thank you for your great effort, and sorry my cross-post before your RFC patch
because I didn't catch it.

I confirmed your RFC patch solved the issue.
I'll also test your v3 patch-series on my environment.

> > [1  <text/plain; us-ascii (quoted-printable)>]
> > On Thu, Dec 13, 2018 at 04:24:28PM +0000, Mark Brown wrote:
> > > On Thu, Dec 13, 2018 at 07:39:45PM +0900, Kunihiko Hayashi wrote:
> > > 
> > > > Maybe I think that we'd better add 'reg' properties to each port,
> > > > however, there might be same matter in other SoCs, so I'm not sure
> > > > whether your patch breaks the backword compatibility or
> > > > our devicetrees are wrong.
> > 
> > > > I'd be glad if I could hear something about this issue from you.
> > 
> > > There's an ongoing thread between Morimoto-san and Tony Lindgren around
> > > the graph card including this issue, there Morimoto-san proposed some
> > > code which would let the reg property be optional.  Device trees should
> > > still be updated but that way we wouldn't actually break anything which
> > > would be good.

Yes. It's desiable to add the reg property in spite of the fixes.
I'll update our devicetrees.

Thank you,

> > 
> > There's a patch now - "[PATCH][RFC] ASoC: simple-card-utils: fixup
> > asoc_simple_card_get_dai_id() ID method".
> > [2 signature.asc <application/pgp-signature (7bit)>]
> > No public key for 24D68B725D5487D0 created at 2018-12-14T03:27:38+0900 using RSA


---
Best Regards,
Kunihiko Hayashi