linux-kernel - Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87va3wz3xh.fsf@linux.intel.com>
Date:   Fri, 14 Dec 2018 14:30:18 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Sekhar Nori <nsekhar@...com>, Peter Chen <hzpeterchen@...il.com>,
        pawell@...ence.com
Cc:     rogerq@...com, devicetree@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        adouglas@...ence.com, jbergsagel@...com, nm@...com,
        sureshp@...ence.com, peter.chen@....com, pjez@...ence.com,
        kurahul@...ence.com
Subject: Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API


Hi,

Sekhar Nori <nsekhar@...com> writes:
>>>>> especially since you already know there is going to be another revision
>>>>> of hardware. It has the advantage that one can easily grep to see which
>>>>> hardware is running current version of controller without having access
>>>>> to the hardware itself. Becomes useful later on when its time to
>>>>> clean-up unused code when boards become obsolete or for requesting
>>>>> testing help.
>>>>
>>>> This doesn't sound like a very strong argument, actually. Specially when
>>>> you consider that, since driver will do revision checking based on
>>>> revision register, you already have strings to grep. Moreover, we don't
>>>> usually drop support just like that.
>>>
>>> AFAICS, it is impossible to know just by grep'ing if there is any
>>> hardware still supported in kernel and using DWC3_REVISION_194A, for
>>> example.
>> 
>> but why do you even care?
>
> When, for example, its coming in the way of some clean-up I am
> attempting to do.

can you share one example when a revision check got in the way of a
cleanup? I fail to see a situation when we need to drop support to older
platforms just to clean some code up.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)