linux-kernel - Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sgz0dci0.fsf@mail.parknet.co.jp>
Date:   Fri, 14 Dec 2018 12:16:07 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Joe Perches <joe@...ches.com>
Cc:     Carmeli Tamir <carmeli.tamir@...il.com>, jthumshirn@...e.de,
        sergey.senozhatsky@...il.com, akpm@...ux-foundation.org,
        axboe@...nel.dk, martin.petersen@...cle.com, bvanassche@....org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12)

Joe Perches <joe@...ches.com> writes:

>>  
>> -#define FAT_FIRST_ENT(s, x)     ((MSDOS_SB(s)->fat_bits == 32 ? 0x0FFFFF00 : \
>> -	MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x))
>> +#define IS_FAT12(sbi) (sbi->fat_bits == 12)
>> +#define IS_FAT16(sbi) (sbi->fat_bits == 16)
>> +#define IS_FAT32(sbi) (sbi->fat_bits == 32)
>
> sbi should be parenthesized or perhaps better these should be
> static inline bool functions

Right, rather this is the bug (not hit yet though) that should be fixed.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>