linux-kernel - Re: KMSAN: uninit-value in __inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Dec 2018 07:14:46 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jon Maloy <jon.maloy@...csson.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
Cc:     "syzbot+c56449ed3652e6720f30@...kaller.appspotmail.com" 
        <syzbot+c56449ed3652e6720f30@...kaller.appspotmail.com>,
        Ying Xue <ying.xue@...driver.com>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        David Miller <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Subject: Re: KMSAN: uninit-value in __inet6_bind



On 12/14/2018 07:04 AM, Jon Maloy wrote:
> 
> 
>> -----Original Message-----
>> From: Cong Wang <xiyou.wangcong@...il.com>
>> Sent: 12-Dec-18 01:17
>> To: Dmitry Vyukov <dvyukov@...gle.com>
>> Cc: syzbot+c56449ed3652e6720f30@...kaller.appspotmail.com; Jon Maloy
>> <jon.maloy@...csson.com>; Ying Xue <ying.xue@...driver.com>; tipc-
>> discussion@...ts.sourceforge.net; David Miller <davem@...emloft.net>;
>> Alexey Kuznetsov <kuznet@....inr.ac.ru>; LKML <linux-
>> kernel@...r.kernel.org>; Linux Kernel Network Developers
>> <netdev@...r.kernel.org>; syzkaller-bugs@...glegroups.com; Hideaki
>> YOSHIFUJI <yoshfuji@...ux-ipv6.org>
>> Subject: Re: KMSAN: uninit-value in __inet6_bind
>>
>> On Tue, Dec 11, 2018 at 1:04 AM Dmitry Vyukov <dvyukov@...gle.com>
>> wrote:
>>>
>>> On Tue, Dec 11, 2018 at 1:41 AM syzbot
>>> <syzbot+c56449ed3652e6720f30@...kaller.appspotmail.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> syzbot found the following crash on:
>>>>
>>>> HEAD commit:    3f06bda61398 kmsan: remove excessive KMSAN
>> wrappers from a..
>>>> git tree:       https://github.com/google/kmsan.git/master
>>>> console output:
>>>> https://syzkaller.appspot.com/x/log.txt?x=13ca6b05400000
>>>> kernel config:
>>>> https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641
>>>> dashboard link:
>> https://syzkaller.appspot.com/bug?extid=c56449ed3652e6720f30
>>>> compiler:       clang version 8.0.0 (trunk 348261)
>>>>
>>>> Unfortunately, I don't have any reproducer for this crash yet.
>>>>
>>>> IMPORTANT: if you fix the bug, please add the following tag to the
>> commit:
>>>> Reported-by: syzbot+c56449ed3652e6720f30@...kaller.appspotmail.com
>>>
>>> This looks like a bug in TIPC, +TIPC maintainers.
>>>
>>
>> It looks more like udp_sock_create6() doesn't initialize
>> udp6_addr.sin6_scope_id.
> 
> Unfortunately udp_sock_create6() has no way of knowing this value, because struct udp_port_cfg is missing a field sin6_scope_id.
> So this has to be fixed first by adding this field to the struct, and then setting it correctly in all current users.
> 

Do we reasons to believe values other than 0 are needed ?