linux-kernel - [tip:x86/urgent] x86/vdso: Pass --eh-frame-hdr to the linker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-cd01544a268ad8ee5b1dfe42c4393f1095f86879@git.kernel.org>
Date:   Sat, 15 Dec 2018 02:45:52 -0800
From:   tip-bot for Alistair Strachan <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, bp@...e.de, labbott@...hat.com, luto@...nel.org,
        carlos@...hat.com, x86@...nel.org, mingo@...nel.org,
        mingo@...hat.com, stable@...r.kernel.org, joel@...lfernandes.org,
        astrachan@...gle.com, linux-kernel@...r.kernel.org,
        fweimer@...hat.com, hjl.tools@...il.com, tglx@...utronix.de
Subject: [tip:x86/urgent] x86/vdso: Pass --eh-frame-hdr to the linker

Commit-ID:  cd01544a268ad8ee5b1dfe42c4393f1095f86879
Gitweb:     https://git.kernel.org/tip/cd01544a268ad8ee5b1dfe42c4393f1095f86879
Author:     Alistair Strachan <astrachan@...gle.com>
AuthorDate: Fri, 14 Dec 2018 14:36:37 -0800
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Sat, 15 Dec 2018 11:37:51 +0100

x86/vdso: Pass --eh-frame-hdr to the linker

Commit

  379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")

accidentally broke unwinding from userspace, because ld would strip the
.eh_frame sections when linking.

Originally, the compiler would implicitly add --eh-frame-hdr when
invoking the linker, but when this Makefile was converted from invoking
ld via the compiler, to invoking it directly (like vmlinux does),
the flag was missed. (The EH_FRAME section is important for the VDSO
shared libraries, but not for vmlinux.)

Fix the problem by explicitly specifying --eh-frame-hdr, which restores
parity with the old method.

See relevant bug reports for additional info:

  https://bugzilla.kernel.org/show_bug.cgi?id=201741
  https://bugzilla.redhat.com/show_bug.cgi?id=1659295

Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")
Reported-by: Florian Weimer <fweimer@...hat.com>
Reported-by: Carlos O'Donell <carlos@...hat.com>
Reported-by: "H. J. Lu" <hjl.tools@...il.com>
Signed-off-by: Alistair Strachan <astrachan@...gle.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Tested-by: Laura Abbott <labbott@...hat.com>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Carlos O'Donell <carlos@...hat.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Joel Fernandes <joel@...lfernandes.org>
Cc: kernel-team@...roid.com
Cc: Laura Abbott <labbott@...hat.com>
Cc: stable <stable@...r.kernel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: X86 ML <x86@...nel.org>
Link: https://lkml.kernel.org/r/20181214223637.35954-1-astrachan@google.com
---
 arch/x86/entry/vdso/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 0624bf2266fd..5bfe2243a08f 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -171,7 +171,8 @@ quiet_cmd_vdso = VDSO    $@
 		 sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@'
 
 VDSO_LDFLAGS = -shared $(call ld-option, --hash-style=both) \
-	$(call ld-option, --build-id) -Bsymbolic
+	$(call ld-option, --build-id) $(call ld-option, --eh-frame-hdr) \
+	-Bsymbolic
 GCOV_PROFILE := n
 
 #