linux-kernel - Re: [PATCH] fix page_count in ->iomap_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <140465544.WOeLnmPe7Q@blindfold>
Date:   Sat, 15 Dec 2018 12:17:01 +0100
From:   Richard Weinberger <richard@....at>
To:     Christoph Hellwig <hch@....de>
Cc:     zhangjun <openzhangj@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Darrick J . Wong" <darrick.wong@...cle.com>, bfoster@...hat.com,
        Dave Chinner <david@...morbit.com>, akpm@...ux-foundation.org,
        kirill.shutemov@...ux.intel.com, mhocko@...e.com,
        n-horiguchi@...jp.nec.com, mgorman@...hsingularity.net,
        aarcange@...hat.com, willy@...radead.org,
        linux@...inikbrodowski.net, linux-mm@...ck.org,
        Gao Xiang <gaoxiang25@...wei.com>
Subject: Re: [PATCH] fix page_count in ->iomap_migrate_page()

Am Samstag, 15. Dezember 2018, 11:51:12 CET schrieb Christoph Hellwig:
> FYI, for iomap we got a patch to just increment the page count when
> setting the private data, and it finally got merged into mainline after
> a while.
> 
> Not that it totally makes sense to me, but it is what it is.  It would
> just be nice if set_page_private took care of it and we had a
> clear_page_private to undo it, making the whole scheme at lot more
> obvious.

Yeah, UBIFS will go the same route. I have already a patch prepared
which increments the page count when UBIFS sets PG_private.

Thanks,
//richard