linux-kernel - Re: [PATCH 07/11] staging: iio: adc: ad7606: Use vendor prefix for DT properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Dec 2018 13:53:05 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Stefan Popa <stefan.popa@...log.com>
Cc:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <Michael.Hennerich@...log.com>, <knaack.h@....de>,
        <lars@...afoo.de>, <pmeerw@...erw.net>,
        <gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <devel@...verdev.osuosl.org>,
        <stefan.popa@...log.co>
Subject: Re: [PATCH 07/11] staging: iio: adc: ad7606: Use vendor prefix for
 DT properties

On Thu, 13 Dec 2018 14:46:19 +0200
Stefan Popa <stefan.popa@...log.com> wrote:

> The 'adi' vendor prefix needs to be added to conversion-start, range,
> first-data and oversampling-ratio properties.
> 
> Signed-off-by: Stefan Popa <stefan.popa@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/adc/ad7606.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7606.c b/drivers/staging/iio/adc/ad7606.c
> index 0925379..3355301 100644
> --- a/drivers/staging/iio/adc/ad7606.c
> +++ b/drivers/staging/iio/adc/ad7606.c
> @@ -322,7 +322,7 @@ static int ad7606_request_gpios(struct ad7606_state *st)
>  {
>  	struct device *dev = st->dev;
>  
> -	st->gpio_convst = devm_gpiod_get(dev, "conversion-start",
> +	st->gpio_convst = devm_gpiod_get(dev, "adi,conversion-start",
>  					 GPIOD_OUT_LOW);
>  	if (IS_ERR(st->gpio_convst))
>  		return PTR_ERR(st->gpio_convst);
> @@ -331,7 +331,8 @@ static int ad7606_request_gpios(struct ad7606_state *st)
>  	if (IS_ERR(st->gpio_reset))
>  		return PTR_ERR(st->gpio_reset);
>  
> -	st->gpio_range = devm_gpiod_get_optional(dev, "range", GPIOD_OUT_LOW);
> +	st->gpio_range = devm_gpiod_get_optional(dev, "adi,range",
> +						 GPIOD_OUT_LOW);
>  	if (IS_ERR(st->gpio_range))
>  		return PTR_ERR(st->gpio_range);
>  
> @@ -340,7 +341,7 @@ static int ad7606_request_gpios(struct ad7606_state *st)
>  	if (IS_ERR(st->gpio_standby))
>  		return PTR_ERR(st->gpio_standby);
>  
> -	st->gpio_frstdata = devm_gpiod_get_optional(dev, "first-data",
> +	st->gpio_frstdata = devm_gpiod_get_optional(dev, "adi,first-data",
>  						    GPIOD_IN);
>  	if (IS_ERR(st->gpio_frstdata))
>  		return PTR_ERR(st->gpio_frstdata);
> @@ -348,7 +349,8 @@ static int ad7606_request_gpios(struct ad7606_state *st)
>  	if (!st->chip_info->has_oversampling)
>  		return 0;
>  
> -	st->gpio_os = devm_gpiod_get_array_optional(dev, "oversampling-ratio",
> +	st->gpio_os = devm_gpiod_get_array_optional(dev,
> +						    "adi,oversampling-ratio",
>  						    GPIOD_OUT_LOW);
>  	return PTR_ERR_OR_ZERO(st->gpio_os);
>  }