linux-kernel - Re: [PATCH] Staging: nvec: nvec: fixed check style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181216230237.f6efaxfj4ejjemf7@gmail.com>
Date:   Sun, 16 Dec 2018 13:02:37 -1000
From:   Joey Pabalinas <joeypabalinas@...il.com>
To:     Amir Mahdi Ghorbanian <indigoomega021@...il.com>
Cc:     marvin24@....de, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
        Joey Pabalinas <joeypabalinas@...il.com>
Subject: Re: [PATCH] Staging: nvec: nvec: fixed check style issues

On Sun, Dec 16, 2018 at 01:43:54PM -0800, Amir Mahdi Ghorbanian wrote:
> Replaced udelay() by the preferred usleep_range() function.
> 
> Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@...il.com>

Nack, usleep_range isn't for atomic contexts like interrupt handlers.

> ---
>  drivers/staging/nvec/nvec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 08027a3..6f35f92 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -626,7 +626,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  		break;
>  	case 2:		/* first byte after command */
>  		if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> -			udelay(33);
> +			usleep_range(0, 33);
>  			if (nvec->rx->data[0] != 0x01) {
>  				dev_err(nvec->dev,
>  					"Read without prior read command\n");
> @@ -713,7 +713,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  	 * We experience less incomplete messages with this delay than without
>  	 * it, but we don't know why. Help is appreciated.
>  	 */
> -	udelay(100);
> +	usleep_range(0, 100);
>  
>  	return IRQ_HANDLED;
>  }
> -- 
> 2.7.4
> 

-- 
Cheers,
Joey Pabalinas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)