linux-kernel - Re: [PATCH v1 6/9] arm64: kexec: no need to ClearPageReserved()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <318b0fe0-1a38-335d-26c1-ad7bac9d811d@suse.com>
Date:   Sun, 16 Dec 2018 11:44:00 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     David Hildenbrand <david@...hat.com>, linux-mm@...ck.org
Cc:     Mark Rutland <mark.rutland@....com>, linux-s390@...r.kernel.org,
        Marc Zyngier <marc.zyngier@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Will Deacon <will.deacon@....com>,
        linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...nel.org>,
        linux-m68k@...ts.linux-m68k.org,
        Dave Kleikamp <dave.kleikamp@...cle.com>,
        linux-mediatek@...ts.infradead.org,
        James Morse <james.morse@....com>,
        linux-riscv@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 6/9] arm64: kexec: no need to ClearPageReserved()



On 14/12/2018 12:10, David Hildenbrand wrote:
> This will be done by free_reserved_page().
> 
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Bhupesh Sharma <bhsharma@...hat.com>
> Cc: James Morse <james.morse@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: Dave Kleikamp <dave.kleikamp@...cle.com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Michal Hocko <mhocko@...nel.org>
> Cc: Matthew Wilcox <willy@...radead.org>
> Acked-by: James Morse <james.morse@....com>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Matthias Brugger <mbrugger@...e.com>

> ---
>  arch/arm64/kernel/machine_kexec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index aa9c94113700..6f0587b5e941 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -361,7 +361,6 @@ void crash_free_reserved_phys_range(unsigned long begin, unsigned long end)
>  
>  	for (addr = begin; addr < end; addr += PAGE_SIZE) {
>  		page = phys_to_page(addr);
> -		ClearPageReserved(page);
>  		free_reserved_page(page);
>  	}
>  }
>