linux-kernel - Re: [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpG-70QdtGoRMbTXS9OGfb_xn2N1VTVnQK_HiZAakRP9Q@mail.gmail.com>
Date:   Mon, 17 Dec 2018 09:07:19 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Sowjanya Komatineni <skomatineni@...dia.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode

On Thu, 13 Dec 2018 at 21:34, Sowjanya Komatineni
<skomatineni@...dia.com> wrote:
>
> V4_MODE is Bit-15 of SDHCI_HOST_CONTROL2 register.
> Need to perform word access to this register.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 99bdae53fa2e..fde984d10619 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -127,12 +127,12 @@ static void sdhci_do_enable_v4_mode(struct sdhci_host *host)
>  {
>         u16 ctrl2;
>
> -       ctrl2 = sdhci_readb(host, SDHCI_HOST_CONTROL2);
> +       ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
>         if (ctrl2 & SDHCI_CTRL_V4_MODE)
>                 return;
>
>         ctrl2 |= SDHCI_CTRL_V4_MODE;
> -       sdhci_writeb(host, ctrl2, SDHCI_HOST_CONTROL);
> +       sdhci_writew(host, ctrl2, SDHCI_HOST_CONTROL2);
>  }
>
>  /*
> --
> 2.7.4
>