linux-kernel - Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217081640.GA16368@kroah.com>
Date:   Mon, 17 Dec 2018 09:16:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Amir Mahdi Ghorbanian <indigoomega021@...il.com>
Cc:     marvin24@....de, devel@...verdev.osuosl.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        ac100@...ts.launchpad.net
Subject: Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:
> @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  		break;
>  	case 2:		/* first byte after command */
>  		if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> -			udelay(33);
> +			usleep_range(0, 33);

Why is this a valid range to sleep for for this device?  Have you been
able to verify/test this?

thanks,

greg k-h