linux-kernel - Re: [PATCH V2 2/3] misc/pvpanic : add pci interface for pvpanic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Dec 2018 17:21:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Peng Hao <peng.hao2@....com.cn>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org, arnd@...db.de,
        andy.shevchenko@...il.com, linux-kernel@...r.kernel.org,
        Peng Hao <peng.hao2@....com.cn>
Subject: Re: [PATCH V2 2/3]  misc/pvpanic : add pci interface for pvpanic

Hi Peng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[cannot apply to v4.20-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Peng-Hao/misc-pvpanic-return-0-for-empty-body-register-function/20181217-151203
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All warnings (new ones prefixed by >>):

   drivers//misc/pvpanic.c: In function 'pvpanic_mmio_init':
>> drivers//misc/pvpanic.c:254:6: warning: 'r1' is used uninitialized in this function [-Wuninitialized]
     if (r1 && r2) /* all drivers register failed */
         ^~

vim +/r1 +254 drivers//misc/pvpanic.c

   244	
   245	static int __init pvpanic_mmio_init(void)
   246	{
   247		int r1, r2;
   248	
   249		if (acpi_disabled)
   250			r1 = platform_driver_register(&pvpanic_mmio_driver);
   251		else
   252			r2 = pvpanic_register_acpi_driver();
   253		r2 = pvpanic_register_pci_drvier();
 > 254		if (r1 && r2) /* all drivers register failed */
   255			return 1;
   256		else
   257			return 0;
   258	}
   259	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (52387 bytes)