linux-kernel - Re: [PATCH net-next] net: bridge: remove unneeded variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9b1e56e-4c37-aff4-b855-2523eae1ef49@cumulusnetworks.com>
Date:   Mon, 17 Dec 2018 11:51:50 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        roopa@...ulusnetworks.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] net: bridge: remove unneeded variable 'err'

On 17/12/2018 11:46, YueHaibing wrote:
> function br_multicast_toggle now always return 0,
> so the variable 'err' is unneeded.
> Also cleanup dead branch in br_changelink.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/bridge/br_multicast.c | 3 +--
>  net/bridge/br_netlink.c   | 4 +---
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 

That is correct, but in such case just make it void.