linux-kernel - Re: [PATCH -next] drm/shmob: Fix return value check in shmob_drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217112523.gm4hsn47v73gsjck@verge.net.au>
Date:   Mon, 17 Dec 2018 12:25:23 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     laurent.pinchart@...asonboard.com,
        kieran.bingham+renesas@...asonboard.com, airlied@...ux.ie,
        daniel@...ll.ch, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/shmob: Fix return value check in
 shmob_drm_probe

On Mon, Dec 17, 2018 at 05:18:30PM +0800, YueHaibing wrote:
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: 8f1597c8f1a5 ("drm: shmobile: Perform initialization/cleanup at probe/remove time")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>