linux-kernel - Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1792812.5VpxBR0bW8@aspire.rjw.lan>
Date:   Mon, 17 Dec 2018 12:45:53 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Kevin Hilman <khilman@...libre.com>, Thomas Meyer <thomas@...3r.de>
Cc:     khilman@...nel.org, nm@...com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.

On Tuesday, December 11, 2018 7:53:05 PM CET Kevin Hilman wrote:
> Thomas Meyer <thomas@...3r.de> writes:
> 
> > NULL check before some freeing functions is not needed.
> >
> > Signed-off-by: Thomas Meyer <thomas@...3r.de>
> 
> Reviewed-by: Kevin Hilman <khilman@...libre.com>
> 
> > ---
> >
> > diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
> >  
> >  	if (sr_info->autocomp_active)
> >  		sr_stop_vddautocomp(sr_info);
> > -	if (sr_info->dbg_dir)
> > -		debugfs_remove_recursive(sr_info->dbg_dir);
> > +	debugfs_remove_recursive(sr_info->dbg_dir);
> >  
> >  	pm_runtime_disable(&pdev->dev);
> >  	list_del(&sr_info->node);
> 

Patch applied, thanks!