linux-kernel - Re: [PATCH] tools/perf: fix silent build with 'make -s'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1194e461-2385-bea9-dc85-d55d4ad89430@yandex-team.ru>
Date:   Mon, 17 Dec 2018 16:39:12 +0300
From:   Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
To:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] tools/perf: fix silent build with 'make -s'

On 17.12.2018 14:47, Konstantin Khlebnikov wrote:
> tools/perf/Makefile conflicts with option '-j'.
> The rest options must be passed as is.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> ---
>   tools/perf/Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 7902a5681fc8..989c3d2f847b 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -16,7 +16,7 @@
>   #
>   # We don't want to pass along options like -j:
>   #
> -unexport MAKEFLAGS
> +MAKEFLAGS := $(filter --j% -j,$(MAKEFLAGS))
>   
>   #
>   # Do a parallel build with multiple jobs, based on the number of CPUs online
> 

Oops, this breaks static build because if LDFLAGS=-static is in command line then
all assignments in makefile are ignored while Makefile.config have a lot of that.