linux-kernel - Re: [PATCH 4/9] staging: rtl8188eu: convert unsigned char arrays to u8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181217135118.GB28400@kroah.com>
Date:   Mon, 17 Dec 2018 14:51:18 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Michael Straube <straube.linux@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] staging: rtl8188eu: convert unsigned char arrays to
 u8

On Sat, Dec 15, 2018 at 05:46:11PM +0100, Michael Straube wrote:
> Covert unsigned char arrays to u8 and make them static and/or const
> where possible.

You are also moving things around here from different .h files in
different places.  Always say exactly what you are doing.

And this too needs to be broken up into smaller pieces, don't make
things static/const when you change the type.

thanks,

greg k-h