linux-kernel - Re: [PATCH v4 3/7] phy: add A3700 COMPHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217164857.68df3f84@xps13>
Date:   Mon, 17 Dec 2018 16:48:57 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Gregory Clement <gregory.clement@...tlin.com>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>
Cc:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Nadav Haklai <nadavh@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Grzegorz Jaszczyk <jaz@...ihalf.com>,
        Evan Wang <xswang@...vell.com>
Subject: Re: [PATCH v4 3/7] phy: add A3700 COMPHY support

Hello,

[...]

> +
> +static int mvebu_a3700_comphy_smc(unsigned long function, unsigned long lane,
> +				  unsigned long mode)
> +{
> +	struct arm_smccc_res res;
> +
> +	arm_smccc_smc(function, lane, mode, 0, 0, 0, 0, 0, &res);

I received the following bug report because I added a dependency on
COMPILE_TEST in Kconfig:

        config: i386-allmodconfig (attached as .config) compiler:
        gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce:
                # save the attached .config to linux build tree
                make ARCH=i386 

        All errors (new ones prefixed by >>):

        >> ERROR: "__arm_smccc_smc" [drivers/phy/marvell/phy-mvebu-a3700-comphy.ko] undefined!  

Unless someone complains, I will drop the dependency on COMPILE_TEST in
Kconfig.

> +
> +	return res.a0;
> +}


Thanks,
Miquèl