linux-kernel - Re: [PATCH v4 3/7] phy: add A3700 COMPHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181217165603.602a7a42@xps13>
Date:   Mon, 17 Dec 2018 16:56:03 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     Gregory Clement <gregory.clement@...tlin.com>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Nadav Haklai <nadavh@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Grzegorz Jaszczyk <jaz@...ihalf.com>,
        Evan Wang <xswang@...vell.com>
Subject: Re: [PATCH v4 3/7] phy: add A3700 COMPHY support

Hi Thomas,

Thomas Petazzoni <thomas.petazzoni@...tlin.com> wrote on Mon, 17 Dec
2018 16:52:23 +0100:

> Hello,
> 
> On Mon, 17 Dec 2018 16:48:57 +0100, Miquel Raynal wrote:
> 
> > I received the following bug report because I added a dependency on
> > COMPILE_TEST in Kconfig:
> > 
> >         config: i386-allmodconfig (attached as .config) compiler:
> >         gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce:
> >                 # save the attached .config to linux build tree
> >                 make ARCH=i386 
> > 
> >         All errors (new ones prefixed by >>):
> >   
> >         >> ERROR: "__arm_smccc_smc" [drivers/phy/marvell/phy-mvebu-a3700-comphy.ko] undefined!      
> > 
> > Unless someone complains, I will drop the dependency on COMPILE_TEST in
> > Kconfig.  
> 
> Keep COMPILE_TEST, and add:
> 
> 	depends on HAVE_ARM_SMCCC
> 
> perhaps ?

Oh that's a cool Kconfig entry. Forgot about it, thanks for the
pointer!


Thanks,
Miquèl