linux-kernel - Re: [PATCH 6/6] psi: introduce psi monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181217162713.GE2218@hirez.programming.kicks-ass.net>
Date:   Mon, 17 Dec 2018 17:27:13 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Suren Baghdasaryan <surenb@...gle.com>
Cc:     gregkh@...uxfoundation.org, tj@...nel.org, lizefan@...wei.com,
        hannes@...xchg.org, axboe@...nel.dk, dennis@...nel.org,
        dennisszhou@...il.com, mingo@...hat.com, akpm@...ux-foundation.org,
        corbet@....net, cgroups@...r.kernel.org, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH 6/6] psi: introduce psi monitor

On Fri, Dec 14, 2018 at 09:15:08AM -0800, Suren Baghdasaryan wrote:
> @@ -358,28 +526,23 @@ static void psi_update_work(struct work_struct *work)
>  {
>  	struct delayed_work *dwork;
>  	struct psi_group *group;
> +	u64 next_update;
>  
>  	dwork = to_delayed_work(work);
>  	group = container_of(dwork, struct psi_group, clock_work);
>  
>  	/*
> +	 * Periodically fold the per-cpu times and feed samples
> +	 * into the running averages.
>  	 */
>  
> +	psi_update(group);
>  
> +	/* Calculate closest update time */
> +	next_update = min(group->polling_next_update,
> +				group->avg_next_update);
> +	schedule_delayed_work(dwork, min(PSI_FREQ,
> +		nsecs_to_jiffies(next_update - sched_clock()) + 1));

See, so I don't at _all_ like how there is no idle option..

>  }