linux-kernel - Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP245DWOSoZ4qXQ-CgUPdRQhHyg6X_7i9h0ctwafGXYS2yZLZQ@mail.gmail.com>
Date:   Tue, 18 Dec 2018 00:20:28 +0530
From:   Amit Kucheria <amit.kucheria@...aro.org>
To:     joe@...ches.com
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>, marc.w.gonzalez@...e.fr,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        nicolas.ferre@...rochip.com, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

On Mon, Dec 17, 2018 at 10:51 PM Joe Perches <joe@...ches.com> wrote:
>
> On Mon, 2018-12-17 at 21:49 +0530, Amit Kucheria wrote:
> > Several drivers didn't have a specific maintainer (other than the
> > subsystem maintainer). Switch to using the 'qcom' and 'msm' regex
> > patterns to capture all of them and add exceptions to the couple of
> > drivers that contain 'msm' but are not related to qcom hardware.
> >
> > Thanks to Marc for the idea to use the N regex.
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -1929,20 +1929,14 @@ M:    Andy Gross <andy.gross@...aro.org>
> >  M:   David Brown <david.brown@...aro.org>
> >  L:   linux-arm-msm@...r.kernel.org
> >  S:   Maintained
> > -F:   Documentation/devicetree/bindings/soc/qcom/
> > -F:   arch/arm/boot/dts/qcom-*.dts
> > -F:   arch/arm/boot/dts/qcom-*.dtsi
> > -F:   arch/arm/mach-qcom/
> > -F:   arch/arm64/boot/dts/qcom/*
> > +N:   qcom
> > +N:   msm
>
> It is generally better to use a comprehensive list of F: patterns
> over N: patterns as N: patterns are not used as properly maintained
> entries for files matched by the get_maintainer.pl script.

I did start with something like the following before the suggestion to use N:

diff --git i/MAINTAINERS w/MAINTAINERS
index 3318f30903b2..a04479053570 100644
--- i/MAINTAINERS
+++ w/MAINTAINERS
@@ -1930,16 +1930,38 @@ M: David Brown <david.brown@...aro.org>
 L: linux-arm-msm@...r.kernel.org
 S: Maintained
 F: Documentation/devicetree/bindings/soc/qcom/
+F: Documentation/devicetree/bindings/*/qcom*
 F: arch/arm/boot/dts/qcom-*.dts
 F: arch/arm/boot/dts/qcom-*.dtsi
 F: arch/arm/mach-qcom/
 F: arch/arm64/boot/dts/qcom/*
+F: drivers/edac/qcom*
+F: drivers/firmware/qcom*
+F: drivers/iio/adc/qcom*
+F: drivers/iommu/qcom*
 F: drivers/i2c/busses/i2c-qup.c
+F: drivers/irqchip/qcom*
+F: drivers/cpufreq/qcom*
 F: drivers/clk/qcom/
+F: drivers/crypto/qcom-*
 F: drivers/dma/qcom/
+F: drivers/hwspinlock/qcom_*
+F: drivers/media/platform/qcom/
+F: drivers/mfd/qcom-*
+F: drivers/mailbox/qcom-*
+F: drivers/misc/qcom-*
+F: drivers/mtd/*/qcom*
+F: drivers/perf/qcom*
+F: drivers/power/*/qcom*
+F: drivers/regulator/qcom*
+F: drivers/remoteproc/qcom*
+F: drivers/rpmsg/qcom*
+F: drivers/slimbus/qcom*
 F: drivers/soc/qcom/
 F: drivers/spi/spi-qup.c
 F: drivers/tty/serial/msm_serial.c
+F: drivers/tty/serial/qcom*
+F: drivers/watchdog/qcom*
 F: drivers/*/pm8???-*
 F: drivers/mfd/ssbi.c
 F: drivers/firmware/qcom_scm*

> git history is used by default for the N: entries and that can
> cause whitespace style commit authors to be cc'd on various changes
> to matched files.

Is that by design? Or can we fix get_maintainer.pl to be less
sensitive to whitespace authorship?

> Also msm is a pretty common filename pattern and the X: exclusions
> for various matching but not associated files might need to be added
> to quite often.
>
> From MAINTAINERS:
>
>         N: Files and directories with regex patterns.
>            N:   [^a-z]tegra     all files whose path contains the word tegra
>            One pattern per line.  Multiple N: lines acceptable.
>            scripts/get_maintainer.pl has different behavior for files that
>            match F: pattern and matches of N: patterns.  By default,
>            get_maintainer will not look at git log history when an F: pattern
>            match occurs.  When an N: match occurs, git log history is used
>            to also notify the people that have git commit signatures.
>
>