linux-kernel - Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181217.111302.105056511088497169.davem@davemloft.net>
Date:   Mon, 17 Dec 2018 11:13:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xuechaojing@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        wulike1@...wei.com, chiqijun@...wei.com, fy.wang@...wei.com,
        tony.qu@...wei.com, luoshaokai@...wei.com, nhorman@...hat.com
Subject: Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

From: Xue Chaojing <xuechaojing@...wei.com>
Date: Sun, 16 Dec 2018 22:32:34 +0000

> In rx_alloc_pkts(), there is no need to schedule a different tasklet for
> refill and it will cause some extra overhead. this patch remove it.
> 
> Suggested-by: Neil Horman <nhorman@...hat.com>
> Signed-off-by: Xue Chaojing <xuechaojing@...wei.com>

In future submissions please formation your Subject line properly.

First, there should always be a space character after the ":" following
the subsystem prefix.

Next, "net-next" belongs inside of the '[]' so "[PATCH net-next N/M] ".

However, when you have a single patch, there is no reason to give the
"N/M" part, so you can just drop it in this situation.

Please also capitalize the text after the subsystem prefix string.

Therefore this Subject must be formatted exactly like this:

	Subject: "[PATCH net-next] hinic: Optimize RX refill buffer mechanism"

But meanwhile you must address the feedback given to you by Neil and myself.

You absolutely MUST NOT receive a RX packet if you cannot successfully
allocate a replacement buffer for the RX ring in that slot.  It allows
the RX ring to become empty, which many cards respond to by hanging.

It would really serve you poorly if you continue to ignore our
feedback because addressing it is a requirement before we will be able
to consider integrating your work.

Thank you.