linux-kernel - Re: [PATCH] tps65218.c: fix IRQ resource leak in tps65218

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f584aab6-374c-5a53-51c5-61098f8bb792@ti.com>
Date:   Mon, 17 Dec 2018 11:31:50 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Lee Jones <lee.jones@...aro.org>,
        Christian Hohnstaedt <Christian.Hohnstaedt@...o.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe()



On 12/14/2018 5:56 PM, Lee Jones wrote:
> On Fri, 14 Dec 2018, Lee Jones wrote:
> 
>> On Thu, 06 Dec 2018, Christian Hohnstaedt wrote:
>>
>>> Free allocated IRQ if reading the device ID fails.
>>
>> The patch is fine.  However, in future please submit patches using the
>> format set (by precedent) by the subsystem.  I will fix the subject
>> for you this time.
>>
>> To check the format, you can do:
>>
>>    `git log --oneline -- <subsystem>`
> 
> Patch applied, by the way.

This would no longer be needed as the bigger clean up is here:

https://lkml.org/lkml/2018/12/9/86

As both are applied it results in a compilation issue.

Lee Jones,

Do you want me to submit a fix patch? Or you can revert this patch?
Anything fine by me.

Let me know.

Thanks,
Keerthy
>