linux-kernel - Re: [PATCH 6/7] sctp: Convert to genradix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181217125001.8e89ac2565417d55ef7a624e@linux-foundation.org>
Date:   Mon, 17 Dec 2018 12:50:01 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Kent Overstreet <kent.overstreet@...il.com>
Cc:     linux-kernel@...r.kernel.org, Vlad Yasevich <vyasevich@...il.com>,
        Neil Horman <nhorman@...driver.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        linux-sctp@...r.kernel.org
Subject: Re: [PATCH 6/7] sctp: Convert to genradix

On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@...il.com> wrote:

> @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc,
>  		goto out;
>  	}
>  
> -	stream->incnt = incnt;
> -	stream->outcnt = outcnt;
> -
>  	asoc->strreset_outstanding = !!out + !!in;
>  

I'm seeing a reject here for some reason.  Using todays's linux-next,
but there are no changes against net/sctp/stream.c in -next.  The
assignment to stream->incnt has disappeared.  I did this:

@@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as
 		goto out;
 	}
 
-	stream->outcnt = outcnt;
-
 	asoc->strreset_outstanding = !!out + !!in;
 
 out:


We're at 4.20-rc7 and this series is rather large.  I'll merge them all
to see what happens, but I don't think it's 4.21-rc1 material?