lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Dec 2018 20:27:26 +0100 From: Daniel Bristot de Oliveira <bristot@...hat.com> To: Steven Rostedt <rostedt@...dmis.org> Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Pavel Tatashin <pasha.tatashin@...cle.com>, Masami Hiramatsu <mhiramat@...nel.org>, Zhou Chengming <zhouchengming1@...wei.com>, Jiri Kosina <jkosina@...e.cz>, Josh Poimboeuf <jpoimboe@...hat.com>, "Peter Zijlstra (Intel)" <peterz@...radead.org>, Chris von Recklinghausen <crecklin@...hat.com>, Jason Baron <jbaron@...mai.com>, Scott Wood <swood@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>, Clark Williams <williams@...hat.com>, x86@...nel.org Subject: Re: [PATCH V2 7/9] x86/alternative: Batch of patch operations On 12/18/18 6:31 PM, Steven Rostedt wrote: > On Tue, 18 Dec 2018 17:46:36 +0100 > Daniel Bristot de Oliveira <bristot@...hat.com> wrote: > >> +void text_poke_bp_batch(struct text_to_poke *tp, unsigned int nr_entries) >> +{ >> + unsigned int i; >> + unsigned char int3 = 0xcc; >> + int patched_all_but_first = 0; >> + >> + bp_int3_tpv = tp; >> + bp_int3_tpv_nr = nr_entries; >> + bp_patching_in_progress = true; >> + /* >> + * Corresponding read barrier in int3 notifier for making sure the >> + * in_progress and handler are correctly ordered wrt. patching. >> + */ >> + smp_wmb(); >> + >> + for (i = 0; i < nr_entries; i++) >> + text_poke_bp_set_handler(tp[i].addr, tp[i].handler, int3); >> + >> + on_each_cpu(do_sync_core, NULL, 1); >> + >> + for (i = 0; i < nr_entries; i++) { >> + if (tp->len - sizeof(int3) > 0) { > Should this be: > > if (tp[i].len - sizeof(int3) > 0) { > > ? Ops! Missed that... you are right. Fixing in the v3. Thanks! -- Daniel
Powered by blists - more mailing lists