linux-kernel - Re: [PATCH v2] sched/wake_q: Reduce reference counting for special users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181218193957.cjx34nn5tku2eaps@linux-r8p5>
Date:   Tue, 18 Dec 2018 11:39:57 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Waiman Long <longman@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Yongji Xie <elohimes@...il.com>, mingo@...hat.com,
        will.deacon@....com, linux-kernel@...r.kernel.org,
        Xie Yongji <xieyongji@...du.com>, zhangyu31@...du.com,
        liuqi16@...du.com, yuanlinsi01@...du.com, nixun@...du.com,
        lilin24@...du.com, andrea.parri@...rulasolutions.com
Subject: Re: [PATCH v2] sched/wake_q: Reduce reference counting for special
 users

On Tue, 18 Dec 2018, Davidlohr Bueso wrote:
>+void wake_q_add_safe(struct wake_q_head *head, struct task_struct *task)
>+{
>+	if (!__wake_q_add(head, task))
>+		get_task_struct(task);

*sigh* and this should be put().