linux-kernel - Re: [PATCH] memory_hotplug: add missing newlines to debugging output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181218212605.4wa35jzlewp3rj7f@master>
Date:   Tue, 18 Dec 2018 21:26:05 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Pavel Tatashin <pasha.tatashin@...een.com>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] memory_hotplug: add missing newlines to debugging output

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
>From: Michal Hocko <mhocko@...e.com>
>
>pages_correctly_probed is missing new lines which means that the line is
>not printed rightaway but it rather waits for additional printks.
>
>Add \n to all three messages in pages_correctly_probed.
>
>Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
>Signed-off-by: Michal Hocko <mhocko@...e.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>

>---
> drivers/base/memory.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>index 0e5985682642..b5ff45ab7967 100644
>--- a/drivers/base/memory.c
>+++ b/drivers/base/memory.c
>@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
> 			return false;
> 
> 		if (!present_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) not present",
>+			pr_warn("section %ld pfn[%lx, %lx) not present\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		} else if (!valid_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
>+			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		} else if (online_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) is already online",
>+			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		}
>-- 
>2.19.2

-- 
Wei Yang
Help you, Help me