linux-kernel - Re: [PATCH] bluetooth: Remove unnecessary smp_mb__after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 00:49:53 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Andrea Parri <andrea.parri@...rulasolutions.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bluetooth: Remove unnecessary smp_mb__after_atomic()
 barriers

Hi Andrea,

> The barriers are redundant because atomic_test_and_clear_bit() already
> provides the required full ordering for the cases in question (that is,
> when the bit is cleared).
> 
> Signed-off-by: Andrea Parri <andrea.parri@...rulasolutions.com>
> ---
> drivers/bluetooth/btusb.c     |  8 ++------
> drivers/bluetooth/hci_intel.c | 16 ++++------------
> 2 files changed, 6 insertions(+), 18 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel