linux-kernel - Re: [PATCH net-next] qlcnic: remove set but not used variables 'op, cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Dec 2018 15:50:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     Shahed.Shaikh@...ium.com, manish.chopra@...ium.com,
        Dept-GELinuxNICDev@...ium.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] qlcnic: remove set but not used variables
 'op, cmd_op'

From: YueHaibing <yuehaibing@...wei.com>
Date: Mon, 17 Dec 2018 17:27:16 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c:1070:5: warning:
>  variable 'op' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c:1342:5: warning:
>  variable 'cmd_op' set but not used [-Wunused-but-set-variable]
> 
> 'op' never used since introduction in commit 7cb03b2347d5 ("qlcnic:
> Support VF-PF communication channel commands.")
> 'cmd_op' not used since commit 6226204bcf20 ("qlcnic: Fix operation
> type and command type.")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.