linux-kernel - Re: [PATCH 01/18] mfd: aat2870-core: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Dec 2018 15:21:08 +0900
From:   jinyoungp <jinyoungp@...dia.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Lee Jones <lee.jones@...aro.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/18] mfd: aat2870-core: Make it explicitly non-modular

Acked-by : Jin Park <jinyoungp@...dia.com>


Thanks,

Jinyoung.


On 12/18/18 5:31 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_AAT2870_CORE
> drivers/mfd/Kconfig:    bool "AnalogicTech AAT2870"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Jin Park <jinyoungp@...dia.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>   drivers/mfd/aat2870-core.c | 40 +++-------------------------------------
>   1 file changed, 3 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
> index 3ba19a45f199..9d3d90d386c2 100644
> --- a/drivers/mfd/aat2870-core.c
> +++ b/drivers/mfd/aat2870-core.c
> @@ -20,7 +20,6 @@
>    */
>   
>   #include <linux/kernel.h>
> -#include <linux/module.h>
>   #include <linux/init.h>
>   #include <linux/debugfs.h>
>   #include <linux/slab.h>
> @@ -349,18 +348,10 @@ static void aat2870_init_debugfs(struct aat2870_data *aat2870)
>   			 "Failed to create debugfs register file\n");
>   }
>   
> -static void aat2870_uninit_debugfs(struct aat2870_data *aat2870)
> -{
> -	debugfs_remove_recursive(aat2870->dentry_root);
> -}
>   #else
>   static inline void aat2870_init_debugfs(struct aat2870_data *aat2870)
>   {
>   }
> -
> -static inline void aat2870_uninit_debugfs(struct aat2870_data *aat2870)
> -{
> -}
>   #endif /* CONFIG_DEBUG_FS */
>   
>   static int aat2870_i2c_probe(struct i2c_client *client,
> @@ -440,20 +431,6 @@ static int aat2870_i2c_probe(struct i2c_client *client,
>   	return ret;
>   }
>   
> -static int aat2870_i2c_remove(struct i2c_client *client)
> -{
> -	struct aat2870_data *aat2870 = i2c_get_clientdata(client);
> -
> -	aat2870_uninit_debugfs(aat2870);
> -
> -	mfd_remove_devices(aat2870->dev);
> -	aat2870_disable(aat2870);
> -	if (aat2870->uninit)
> -		aat2870->uninit(aat2870);
> -
> -	return 0;
> -}
> -
>   #ifdef CONFIG_PM_SLEEP
>   static int aat2870_i2c_suspend(struct device *dev)
>   {
> @@ -492,15 +469,14 @@ static const struct i2c_device_id aat2870_i2c_id_table[] = {
>   	{ "aat2870", 0 },
>   	{ }
>   };
> -MODULE_DEVICE_TABLE(i2c, aat2870_i2c_id_table);
>   
>   static struct i2c_driver aat2870_i2c_driver = {
>   	.driver = {
> -		.name	= "aat2870",
> -		.pm	= &aat2870_pm_ops,
> +		.name			= "aat2870",
> +		.pm			= &aat2870_pm_ops,
> +		.suppress_bind_attrs	= true,
>   	},
>   	.probe		= aat2870_i2c_probe,
> -	.remove		= aat2870_i2c_remove,
>   	.id_table	= aat2870_i2c_id_table,
>   };
>   
> @@ -509,13 +485,3 @@ static int __init aat2870_init(void)
>   	return i2c_add_driver(&aat2870_i2c_driver);
>   }
>   subsys_initcall(aat2870_init);
> -
> -static void __exit aat2870_exit(void)
> -{
> -	i2c_del_driver(&aat2870_i2c_driver);
> -}
> -module_exit(aat2870_exit);
> -
> -MODULE_DESCRIPTION("Core support for the AnalogicTech AAT2870");
> -MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Jin Park <jinyoungp@...dia.com>");