linux-kernel - Re: [PATCH v6 4/6] mm: Shuffle initial free memory to improve memory-side-cache utilization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201812181410.zF3l3lpN%fengguang.wu@intel.com>
Date:   Tue, 18 Dec 2018 14:30:15 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     kbuild-all@...org, akpm@...ux-foundation.org,
        Michal Hocko <mhocko@...e.com>,
        Kees Cook <keescook@...omium.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        peterz@...radead.org, linux-mm@...ck.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, mgorman@...e.de
Subject: Re: [PATCH v6 4/6] mm: Shuffle initial free memory to improve
 memory-side-cache utilization

Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc7 next-20181217]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dan-Williams/mm-Randomize-free-memory/20181218-130230
config: x86_64-randconfig-x010-201850 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   mm/memblock.c: In function 'memblock_set_sidecache':
>> mm/memblock.c:859:4: error: too many arguments to function 'page_alloc_shuffle'
       page_alloc_shuffle(SHUFFLE_ENABLE);
       ^~~~~~~~~~~~~~~~~~
   In file included from mm/memblock.c:20:0:
   include/linux/shuffle.h:43:20: note: declared here
    static inline void page_alloc_shuffle(void)
                       ^~~~~~~~~~~~~~~~~~

vim +/page_alloc_shuffle +859 mm/memblock.c

   825	
   826	#ifdef CONFIG_HAVE_MEMBLOCK_CACHE_INFO
   827	/**
   828	 * memblock_set_sidecache - set the system memory cache info
   829	 * @base: base address of the region
   830	 * @size: size of the region
   831	 * @cache_size: system side cache size in bytes
   832	 * @direct: true if the cache has direct mapped associativity
   833	 *
   834	 * This function isolates region [@base, @base + @size), and saves the cache
   835	 * information.
   836	 *
   837	 * Return: 0 on success, -errno on failure.
   838	 */
   839	int __init_memblock memblock_set_sidecache(phys_addr_t base, phys_addr_t size,
   840				   phys_addr_t cache_size, bool direct_mapped)
   841	{
   842		struct memblock_type *type = &memblock.memory;
   843		int i, ret, start_rgn, end_rgn;
   844	
   845		ret = memblock_isolate_range(type, base, size, &start_rgn, &end_rgn);
   846		if (ret)
   847			return ret;
   848	
   849		for (i = start_rgn; i < end_rgn; i++) {
   850			struct memblock_region *r = &type->regions[i];
   851	
   852			r->cache_size = cache_size;
   853			r->direct_mapped = direct_mapped;
   854			/*
   855			 * Enable randomization for amortizing direct-mapped
   856			 * memory-side-cache conflicts.
   857			 */
   858			if (r->size > r->cache_size && r->direct_mapped)
 > 859				page_alloc_shuffle(SHUFFLE_ENABLE);
   860		}
   861	
   862		return 0;
   863	}
   864	#endif
   865	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29217 bytes)