linux-kernel - Re: [PATCH v2 18/19] mailbox: stm32-ipcc: Use device-managed registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e342d360-8b3e-f9a1-fef4-4e53b346cf5e@st.com>
Date:   Tue, 18 Dec 2018 09:26:14 +0100
From:   Ludovic BARRE <ludovic.barre@...com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jassi Brar <jassisinghbrar@...il.com>
CC:     <linux-kernel@...r.kernel.org>,
        Fabien Dessenne <fabien.dessenne@...com>
Subject: Re: [PATCH v2 18/19] mailbox: stm32-ipcc: Use device-managed
 registration API



On 12/17/18 4:02 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> Get rid of some boilerplate driver removal code by using the newly added
> device-managed registration API.
> 
> Cc: Fabien Dessenne <fabien.dessenne@...com>
> Cc: Ludovic Barre <ludovic.barre@...com>

Reviewed-by: Ludovic Barre <ludovic.barre@...com>

Regards,
Ludo

> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>   drivers/mailbox/stm32-ipcc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
> index 533b0da5235d..a338bd4cd7db 100644
> --- a/drivers/mailbox/stm32-ipcc.c
> +++ b/drivers/mailbox/stm32-ipcc.c
> @@ -299,7 +299,7 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
>   	for (i = 0; i < ipcc->controller.num_chans; i++)
>   		ipcc->controller.chans[i].con_priv = (void *)i;
>   
> -	ret = mbox_controller_register(&ipcc->controller);
> +	ret = devm_mbox_controller_register(dev, &ipcc->controller);
>   	if (ret)
>   		goto err_irq_wkp;
>   
> @@ -329,8 +329,6 @@ static int stm32_ipcc_remove(struct platform_device *pdev)
>   {
>   	struct stm32_ipcc *ipcc = platform_get_drvdata(pdev);
>   
> -	mbox_controller_unregister(&ipcc->controller);
> -
>   	if (ipcc->wkp)
>   		dev_pm_clear_wake_irq(&pdev->dev);
>   
>