linux-kernel - Re: [PATCH v2] mfd: cros_ec: Add commands to control codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFv8Nw+RbzKrjE1tsgxdRntXKWp9XVq8hbP7MZ3mZ=a2rMyG2Q@mail.gmail.com>
Date:   Tue, 18 Dec 2018 16:37:27 +0800
From:   Cheng-yi Chiang <cychiang@...omium.org>
To:     Lee Jones <lee.jones@...aro.org>, bleung@...omium.org,
        groeck@...omium.org
Cc:     linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        alsa-devel@...a-project.org, Dylan Reid <dgreid@...omium.org>,
        tzungbi@...omium.org, Rohit kumar <rohitkr@...eaurora.org>,
        scollyer@...omium.org
Subject: Re: [PATCH v2] mfd: cros_ec: Add commands to control codec

+Benson, Guenter, Scott

On Fri, Dec 14, 2018 at 8:22 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> On Fri, 14 Dec 2018, Lee Jones wrote:
>
> > On Thu, 06 Dec 2018, Cheng-Yi Chiang wrote:
> >
> > > Add EC host commands to control codec on EC.
> > >
> > > Signed-off-by: Cheng-Yi Chiang <cychiang@...omium.org>
> > > ---
> > >  V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree.
> > >  Codec driver that uses these commands will be sent separately.
> > >  Thanks!
> > >
> > >  include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
> > >  1 file changed, 94 insertions(+)
> >
> > Would be good to have this reviewed by some more Chrome people.
>
> See this for reference:
>
>   https://lore.kernel.org/patchwork/patch/1024985/

Hi Benson and Guenter,
Could you please review this patch ?
The corresponding implementation at EC side by Scott is at
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1356185

Thanks a lot!

>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog