linux-kernel - Re: [PATCH] ima: define ima_create_tmpfile() hook and add missing call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201812180855.A0njLyvC%fengguang.wu@intel.com>
Date:   Tue, 18 Dec 2018 08:43:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>
Cc:     kbuild-all@...org, Ignaz Forster <iforster@...e.de>,
        linux-integrity <linux-integrity@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Goldwyn Rodrigues <rgoldwyn@...e.com>,
        Fabian Vogt <fvogt@...e.de>, Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH] ima: define ima_create_tmpfile() hook and add missing
 call

Hi Mimi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.20-rc7 next-20181217]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mimi-Zohar/ima-define-ima_create_tmpfile-hook-and-add-missing-call/20181218-081329
config: x86_64-randconfig-x006-201850 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from fs//attr.c:19:0:
   include/linux/ima.h: In function 'ima_post_create_tmpfile':
>> include/linux/ima.h:47:9: warning: 'return' with a value, in function returning void
     return 0;
            ^
   include/linux/ima.h:45:20: note: declared here
    static inline void ima_post_create_tmpfile(const struct file *file)
                       ^~~~~~~~~~~~~~~~~~~~~~~

vim +/return +47 include/linux/ima.h

    44	
    45	static inline void ima_post_create_tmpfile(const struct file *file)
    46	{
  > 47		return 0;
    48	}
    49	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (33692 bytes)