linux-kernel - Re: [PATCH 12/18] mfd: tps80031: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12b9a17a-bcba-2941-c77e-5e58228b8f02@nvidia.com>
Date:   Tue, 18 Dec 2018 15:37:44 +0530
From:   Laxman Dewangan <ldewangan@...dia.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Lee Jones <lee.jones@...aro.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 12/18] mfd: tps80031: Make it explicitly non-modular



On Tuesday 18 December 2018 02:01 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_TPS80031
> drivers/mfd/Kconfig:    bool "TI TPS80031/TPS80032 Power Management chips"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
>
> We don't replace module.h with init.h since the file already has that.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Laxman Dewangan <ldewangan@...dia.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>

Acked-by: Laxman Dewangan <ldewangan@...dia.com>