linux-kernel - Re: [PATCH 6/6] psi: introduce psi monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181218104622.GB15430@hirez.programming.kicks-ass.net>
Date:   Tue, 18 Dec 2018 11:46:22 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Suren Baghdasaryan <surenb@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tejun Heo <tj@...nel.org>, lizefan@...wei.com,
        Johannes Weiner <hannes@...xchg.org>, axboe@...nel.dk,
        dennis@...nel.org, Dennis Zhou <dennisszhou@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>, cgroups@...r.kernel.org,
        linux-mm <linux-mm@...ck.org>, linux-doc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@...roid.com
Subject: Re: [PATCH 6/6] psi: introduce psi monitor

On Mon, Dec 17, 2018 at 05:21:05PM -0800, Suren Baghdasaryan wrote:
> On Mon, Dec 17, 2018 at 8:22 AM Peter Zijlstra <peterz@...radead.org> wrote:

> > How well has this thing been fuzzed? Custom string parser, yay!
> 
> Honestly, not much. Normal cases and some obvious corner cases. Will
> check if I can use some fuzzer to get more coverage or will write a
> script.
> I'm not thrilled about writing a custom parser, so if there is a
> better way to handle this please advise.

The grammar seems fairly simple, something like:

  some-full = "some" | "full" ;
  threshold-abs = integer ;
  threshold-pct = integer, { "%" } ;
  threshold = threshold-abs | threshold-pct ;
  window = integer ;
  trigger = some-full, space, threshold, space, window ;

And that could even be expressed as two scanf formats:

 "%4s %u%% %u" , "%4s %u %u"

which then gets your something like:

  char type[5];

  if (sscanf(input, "%4s %u%% %u", &type, &pct, &window) == 3) {
  	// do pct thing
  } else if (sscanf(intput, "%4s %u %u", &type, &thres, &window) == 3) {
  	// do abs thing
  } else return -EFAIL;

  if (!strcmp(type, "some")) {
  	// some
  } else if (!strcmp(type, "full")) {
  	// full
  } else return -EFAIL;

  // do more

which seems like a lot less error prone. Alternatively you can use 4
formats:

  "some %u%% %u" "some %u %u"
  "full %u%% %u" "full %u %u"

and avoid the whole 'type' thing.