lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 18 Dec 2018 21:46:41 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     <devel@...verdev.osuosl.org>, <gregkh@...uxfoundation.org>,
        <leobras.c@...il.co>, <radek.dostal@...eamunlimited.co>,
        <linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2 -next] staging: fbtft: use strcmp() instead of
 strncmp() for

On 2018/12/18 21:37, Dan Carpenter wrote:
> On Tue, Dec 18, 2018 at 09:25:08PM +0800, YueHaibing wrote:
>> strncmp() stops comparing when either the end of one of the first two 
>> arguments is reached or when 'n' characters have been compared, whichever
>> comes first.That means that strncmp(s1, s2, n) is equivalent to 
>> strcmp(s1, s2) if n exceeds the length of s1 or the length of s2.
>>
>> This patch avoids that the following warning is reported by smatch:
>>
>> drivers/staging/fbtft/fbtft_device.c:1458
>>  fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32)
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>> v2: fix patch title
> 
> v2 is worse than v1...

Yes, ...., I messed up.

I will fix it.

> 
> v1 is a little long but I wouldn't have complained about it.
> 
> Please assume that the subject and the commit message are separate
> things.  Take a look how the patch description reads on marc.info:
> 
> https://marc.info/?l=linux-driver-devel&m=154513957719226&w=2
> 
> regards,
> dan carpenter
> 
> 
> .
> 

Powered by blists - more mailing lists