linux-kernel - Re: [PATCH v6 1/6] acpi: Create subtable parsing infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201812182126.tR18M3fq%fengguang.wu@intel.com>
Date:   Tue, 18 Dec 2018 21:39:49 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     kbuild-all@...org, akpm@...ux-foundation.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Keith Busch <keith.busch@...el.com>, peterz@...radead.org,
        dave.hansen@...ux.intel.com, linux-mm@...ck.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, mgorman@...e.de
Subject: Re: [PATCH v6 1/6] acpi: Create subtable parsing infrastructure

Hi Keith,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc7 next-20181218]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dan-Williams/mm-Randomize-free-memory/20181218-130230
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

   arch/arm64/kernel/smp.c: In function 'acpi_parse_and_init_cpus':
>> arch/arm64/kernel/smp.c:577:11: error: passing argument 2 of 'acpi_table_parse_madt' from incompatible pointer type [-Werror=incompatible-pointer-types]
              acpi_parse_gic_cpu_interface, 0);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/arm64/kernel/smp.c:20:0:
   include/linux/acpi.h:249:5: note: expected 'acpi_tbl_entry_handler {aka int (*)(union acpi_subtable_headers *, const long unsigned int)}' but argument is of type 'int (*)(struct acpi_subtable_header *, const long unsigned int)'
    int acpi_table_parse_madt(enum acpi_madt_type id,
        ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   arch/arm64/kernel/acpi_numa.c: In function 'acpi_map_cpus_to_nodes':
>> arch/arm64/kernel/acpi_numa.c:88:10: error: passing argument 4 of 'acpi_table_parse_entries' from incompatible pointer type [-Werror=incompatible-pointer-types]
             acpi_parse_gicc_pxm, 0);
             ^~~~~~~~~~~~~~~~~~~
   In file included from arch/arm64/kernel/acpi_numa.c:19:0:
   include/linux/acpi.h:242:12: note: expected 'acpi_tbl_entry_handler {aka int (*)(union acpi_subtable_headers *, const long unsigned int)}' but argument is of type 'int (*)(struct acpi_subtable_header *, const long unsigned int)'
    int __init acpi_table_parse_entries(char *id, unsigned long table_size,
               ^~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/acpi_table_parse_madt +577 arch/arm64/kernel/smp.c

e1896249 Lorenzo Pieralisi 2018-06-25  566  
e1896249 Lorenzo Pieralisi 2018-06-25  567  static void __init acpi_parse_and_init_cpus(void)
e1896249 Lorenzo Pieralisi 2018-06-25  568  {
e1896249 Lorenzo Pieralisi 2018-06-25  569  	int i;
e1896249 Lorenzo Pieralisi 2018-06-25  570  
e1896249 Lorenzo Pieralisi 2018-06-25  571  	/*
e1896249 Lorenzo Pieralisi 2018-06-25  572  	 * do a walk of MADT to determine how many CPUs
e1896249 Lorenzo Pieralisi 2018-06-25  573  	 * we have including disabled CPUs, and get information
e1896249 Lorenzo Pieralisi 2018-06-25  574  	 * we need for SMP init.
e1896249 Lorenzo Pieralisi 2018-06-25  575  	 */
e1896249 Lorenzo Pieralisi 2018-06-25  576  	acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT,
e1896249 Lorenzo Pieralisi 2018-06-25 @577  				      acpi_parse_gic_cpu_interface, 0);
e1896249 Lorenzo Pieralisi 2018-06-25  578  
e1896249 Lorenzo Pieralisi 2018-06-25  579  	/*
e1896249 Lorenzo Pieralisi 2018-06-25  580  	 * In ACPI, SMP and CPU NUMA information is provided in separate
e1896249 Lorenzo Pieralisi 2018-06-25  581  	 * static tables, namely the MADT and the SRAT.
e1896249 Lorenzo Pieralisi 2018-06-25  582  	 *
e1896249 Lorenzo Pieralisi 2018-06-25  583  	 * Thus, it is simpler to first create the cpu logical map through
e1896249 Lorenzo Pieralisi 2018-06-25  584  	 * an MADT walk and then map the logical cpus to their node ids
e1896249 Lorenzo Pieralisi 2018-06-25  585  	 * as separate steps.
e1896249 Lorenzo Pieralisi 2018-06-25  586  	 */
e1896249 Lorenzo Pieralisi 2018-06-25  587  	acpi_map_cpus_to_nodes();
e1896249 Lorenzo Pieralisi 2018-06-25  588  
e1896249 Lorenzo Pieralisi 2018-06-25  589  	for (i = 0; i < nr_cpu_ids; i++)
e1896249 Lorenzo Pieralisi 2018-06-25  590  		early_map_cpu_to_node(i, acpi_numa_get_nid(i));
e1896249 Lorenzo Pieralisi 2018-06-25  591  }
0f078336 Lorenzo Pieralisi 2015-05-13  592  #else
e1896249 Lorenzo Pieralisi 2018-06-25  593  #define acpi_parse_and_init_cpus(...)	do { } while (0)
0f078336 Lorenzo Pieralisi 2015-05-13  594  #endif
0f078336 Lorenzo Pieralisi 2015-05-13  595  

:::::: The code at line 577 was first introduced by commit
:::::: e189624916961c735c18e3c75acc478661403830 arm64: numa: rework ACPI NUMA initialization

:::::: TO: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
:::::: CC: Will Deacon <will.deacon@....com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (40931 bytes)